OK, So it looks like the consensus was src/platform? Also, are we doing that resource tag, or is it cool if I just leave this as using the source tag. I'm going to be merging this in the next two days.
On Tue, Dec 3, 2013 at 6:01 PM, Brian LeRoux <b...@brian.io> wrote: > src/platform seems simplest to me > On Dec 4, 2013 7:09 AM, "Steven Gill" <stevengil...@gmail.com> wrote: > >> I think it looks good! >> >> I noticed that you created a top level res folder in the plugin to store >> your resources. This rises the question about where should resources live >> within a plugin. >> >> Two options I see are: >> 1) Create the res folder with platform folders within to store resources. >> (this is what joe is doing in the repo above) >> 2) Keep resources in src/platform (I believe iOS bundles resources in >> .bundle which is stored in src/ios for certain plugins) >> >> Thoughts on which one makes the sense? >> >> >> On Tue, Dec 3, 2013 at 10:57 AM, Joe Bowser <bows...@gmail.com> wrote: >> >> > Oh crap, here's my GitHub fork of what I did: >> > https://github.com/infil00p/cordova-plugin-inappbrowser/tree/drawables >> > >> > >> > >> > On Tue, Dec 3, 2013 at 10:57 AM, Joe Bowser <bows...@gmail.com> wrote: >> > > Hey >> > > >> > > I just did some hacking on the InAppBrowser UI, and I've added the >> > > ability to add drawables. I've used the Android drawables, which I >> > > believe to have an acceptable licence and now we have something >> > > resembling a real Android UI. I think there will probably need to be >> > > some more tweaking to get the icons to look right, but I think this >> > > looks a LOT better than what we had previously. >> > > >> > > I also wanted to discuss using the source tag to transport assets in >> > > plugins. It seems to work fine, but I'm wondering if anyone had any >> > > strong opinions about what I did here before I push this fix up to the >> > > InAppBrowser. >> > > >> > > Joe >> > >>
