Really cool. So the only part that is missing now is the ability to just hit the "merge this PR and close". I can live with that! Great stuff.
On Tue, Feb 25, 2014 at 1:05 PM, Ian Clelland <iclell...@google.com> wrote: > On Tue, Feb 25, 2014 at 12:54 PM, Shazron <shaz...@gmail.com> wrote: > > > Something I noticed from a commit from Ian: > > https://github.com/apache/cordova-plugin-file-transfer/pull/20 > > > > The github user "asfgit" automatically closed the PR from that commit -- > I > > believe github scans the commit message to associate it with an issue/PR > > but not sure how it knows it was a merge. The relevant words in the > message > > are "closes #20". > > > > I was hoping that would happen when I wrote that commit line; I'll admit > that I didn't have very high hopes for it, though. > > > > > > Github has a way to refer to repos and issues, so this PR issue would be > > "apache/cordova-plugin-file-transfer#20" so if we added to the commit > > message "Closes apache/cordova-plugin-file-transfer#20" it should close > the > > corresponding PR/issue (I hope). > > > > Is the full repo name required? I thought that the example above shows that > it isn't, and we just need to ensure that we use one of the magic verbs and > mention the PR by number? > > > > > > > > On Tue, Feb 25, 2014 at 6:33 AM, Michal Mocny <mmo...@chromium.org> > wrote: > > > > > This is a sweet improvement, but if I read correct, doesn't address our > > > biggest headaches: > > > > > > 1. You still cannot merge in PR from github > > > 2. We still cannot close PR ourselves > > > 3. Commits already automatically comment on corresponding JIRA issues, > so > > > this change merely bumps the timing of automatic JIRA references to > > > comments up a bit (helps discoverability, but doesn't in the end help > > > manage JIRA issues all that much). > > > > > > Perhaps the most interesting change is the better discoverability of PR > > > from then dev ML without requiring explicit emails from the > contributor, > > > and our ability to reply directly from ML. > > > > > > -Michal > > > > > > > > > On Tue, Feb 25, 2014 at 7:24 AM, Ian Clelland <iclell...@chromium.org > > > >wrote: > > > > > > > Yes, and can we have a pony, too? > > > > > > > > Seriously, everything on that list is a huge improvement over the > > > > mostly-one-way-replication that we're working with now. > > > > > > > > Thanks for filing that. > > > > > > > > > > > > On Tue, Feb 25, 2014 at 12:17 AM, Shazron <shaz...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > https://blogs.apache.org/infra/entry/improved_integration_between_apache_and > > > > > > > > > > Do we want everything on that list? I can file the issue... > > > > > > > > > > > > > > >
