+1 For historical context, there was a time when finding/retaining committers was more important than concern about the fickle style of JS that came into fashion that week. We would even accept a pull request if it had tabs instead of spaces!
But ya lets go bananas on JSHint. Cleaning up those warnings would be a good 'first bug' for new committers. On Mon, Jun 16, 2014 at 6:52 PM, Ian Clelland <[email protected]> wrote: > /* jshint laxcomma: true */ > > at the top of a JS file should do it. > > Ref: http://www.jshint.com/docs/options/#laxcomma > > > On Mon, Jun 16, 2014 at 9:34 PM, Andrew Grieve <[email protected]> > wrote: > > > I haven't seen our style guide followed, and generally don't think style > is > > a thing that can really be enforced without tools or code review. How > about > > deleting the wiki page and doubling down on jshint? Can we tell jshint to > > force ;s while allowing comma-first? > > > > > > On Mon, Jun 16, 2014 at 5:00 PM, Mark Koudritsky <[email protected]> > > wrote: > > > > > To make it clear, I don't really care whether to use semicolons or not, > > but > > > I do want cordova to have a style guide which I can follow without > > > surprising people too much. Which is obviously not the case with our > > > current style guide :) > > > > > >
