Already did that. Let's do another vote thread!
On Wed, Sep 3, 2014 at 4:05 PM, Jesse <purplecabb...@gmail.com> wrote: > Joe, afaik, this vote has already failed. > Make your changes, and let us know when they are in and retagged, and > Android will get packaged along with the rest. > Then we can start a new vote thread. > > @purplecabbage > risingj.com > > > On Wed, Sep 3, 2014 at 3:44 PM, Joe Bowser <bows...@gmail.com> wrote: > > > -1 > > > > I had to re-tag 3.6.0, so we should redo this with the regression fix. > > > > > > On Wed, Sep 3, 2014 at 3:43 PM, Jesse <purplecabb...@gmail.com> wrote: > > > > > I have applied Josh's changes to master, and cherry-picked into the > 3.6.x > > > branch. > > > I have updated 3.6.x package.json with the correct version number, and > > > re-tagged it 3.6.0. > > > wp8 should be good to go. > > > > > > Should just be this now: > > > coho create-archive -r wp8 -r windows --dest cordova-dist-dev/$JIRA > --tag > > > 3.6.0 > > > > > > @purplecabbage > > > risingj.com > > > > > > > > > On Wed, Sep 3, 2014 at 6:34 AM, Sergey Grebnov (Akvelon) < > > > v-seg...@microsoft.com> wrote: > > > > > > > Thx, Josh! Another reason of moving node_modules to bin was > consistency > > > > with Android and Windows. > > > > > > > > Thx! > > > > Sergey > > > > -----Original Message----- > > > > From: Josh Soref [mailto:jso...@blackberry.com] > > > > Sent: Wednesday, September 3, 2014 3:21 PM > > > > To: Cordova Dev > > > > Subject: Re: [Vote] 3.6.0 Cadence Release (attempt 2) > > > > > > > > Sergey wrote: > > > > > #2 cordova-wp8 distributed to npm has 'node_modules' folder missing > > so > > > > fails to install (this is due to 'npm pack' specific logic which > > removed > > > > this folder, we should move node_modules to bin, will push a fix for > > this > > > > in master soon). > > > > > > > > No need for that, just add bundledDependencies to get package.json, > see > > > > what we did for BlackBerry. > > > > > > > > > >
