Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/132#discussion_r19540066
--- Diff: framework/src/org/apache/cordova/AndroidWebView.java ---
@@ -354,7 +349,9 @@ private void loadUrlNow(String url) {
if (LOG.isLoggable(LOG.DEBUG) && !url.startsWith("javascript:")) {
LOG.d(TAG, ">>> loadUrlNow()");
}
- if (url.startsWith("file://") || url.startsWith("javascript:") ||
internalWhitelist.isUrlWhiteListed(url)) {
+ Boolean shouldAllowNavigation =
pluginManager.shouldAllowNavigation(url);
+ if (url.startsWith("file://") || url.startsWith("javascript:") ||
--- End diff --
Since shouldAllowNavigtion is tri-state, I think we should do the default
behaviour only when non-null
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
