Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/132#discussion_r19540914
--- Diff:
framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java ---
@@ -72,8 +72,14 @@ public WebResourceResponse
shouldInterceptRequest(WebView view, String url) {
}
private boolean isUrlHarmful(String url) {
- return ((url.startsWith("http:") || url.startsWith("https:")) &&
!appView.getWhitelist().isUrlWhiteListed(url))
- || url.contains("app_webview");
+ Boolean shouldAllowRequest =
appView.getPluginManager().shouldAllowRequest(url);
+ if (shouldAllowRequest == null || shouldAllowRequest == true) {
+ // This is the behaviour when all plugins return true, and is
also the default behaviour
+ // if no plugins override shouldAllowRequest()
+ return ((url.startsWith("file://") || url.startsWith("data:"))
&& url.contains("app_webview"));
--- End diff --
same nit about app_webview
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
