Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/132#discussion_r19541119
  
    --- Diff: framework/src/org/apache/cordova/PluginManager.java ---
    @@ -254,6 +254,110 @@ public void onNewIntent(Intent intent) {
         }
     
         /**
    +     * Called when the webview is going to request an external resource.
    +     *
    +     * This delegates to the installed plugins, which must all return true 
for
    +     * this method to return true.
    +     *
    +     * @param url       The URL that is being requested.
    +     * @return          Tri-State:
    +     *                    null: All plugins returned null (the default). 
This
    +     *                          indicates that the default policy should be
    +     *                          followed.
    +     *                    true: All plugins returned true (allow the 
resource
    --- End diff --
    
    Why not just return the first non-null value?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to