Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74284189
Save logic is a bit disorganized because I was expecting @omefire to
implement it for plugins as well, so I have whipped up something. I will
probably make another pass with the syntax change for plugins on config.xml.
Here are some notes
* **no version on save:** The original save command implementation had a
flag called -shrinkwrap that was used to indicate that you want to persist the
version for the plugin to config.xml, without such a flag users need to know
the plugin version beforehand to be able to pin. I am a bit conflicted about
what to do without such a flag.
* ** retrieving the version from config.xml:** I have already added a check
for this but I am failing to see how this feature is used. If an entry for a
plugin already exists on config.xml, it will be restored (provided that this PR
is applied) the moment that you try to do something useful with CLI (run,build,
prepare, add another plugin) so the only way this feature will be executed is
if you clone a project and try to add the plugin immediately before issuing any
other commands.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
