Michal: I'm new to this area - can you please elaborate why this change could potentially break downstream distributions? IS there an API change?
-Nikhil -----Original Message----- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Thursday, March 5, 2015 1:12 PM To: dev Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib Alight, remote branches (named copy-from-app-hello-world) are created for cordova-lib, cordova-cli, and cordova-app-hello-world. There are still 2 failing cordova-lib tests, but I'm working to resolve that. My actual end-to-end tests appear to be working with all use cases. Please, please: if you develop a downstream distribution that uses cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this out and see if it works for you. I will do so for cca. Please forward this to anyone on your team responsible for this work! -Michal On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal <nikhi...@microsoft.com> wrote: > I like moving this to npm because Apache Git as a distribution > mechanism for the hello world app has been less reliable than desirable in > the past. > > Thanks, > Nikhil > > > -----Original Message----- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Tuesday, March 3, 2015 12:08 PM > To: Michal Mocny > Cc: dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Pushed first attempt to remote branches: > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > - > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > ello-world > > Cleaning up cordova-lib is strictly required, though I think we should > still take the opportunity to do so. > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny <mmo...@chromium.org> wrote: > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > (its already included with the platform). > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > I guess, though, that we could consider changing the platform create > > scripts to import config.xml's, since they currently do not. This > > may be difficult given that the format is different even though the > > name is the same (platform vs project config). > > > > -Michal > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse <purplecabb...@gmail.com> wrote: > > > >> +1 > >> Does this affect the ability to use an individual platform? > >> ie. cordova-ios/bin/create ... > >> Will platform create scripts need to change? > >> > >> > >> > >> @purplecabbage > >> risingj.com > >> > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny <mmo...@google.com> > wrote: > >> > >> > This came up in the context of whitelist discussion, but wanted > >> > to > >> bring it > >> > to everyones attention. > >> > > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 > >> > > >> > We would like the default app to support installing the whitelist > >> > plugin automatically using the new plugin auto-restore feature > >> > (If you > >> disagree, > >> > discuss on the whitelist thread, that is not the topic of this post). > >> > > >> > However, the cordova-lib create script cannot support this > >> > feature right now anyway (that is the topic of this post). I've > >> > outlined in the JIRA > >> how > >> > we could fix that (open to feedback). > >> > > >> > TLDR; --copy-from already supports this, so lets just vastly > >> > simplify cordova-lib create.js to just always do a --copy-from > >> > (or --link-to), > >> and > >> > change cordova-cli to provide the default > >> > --copy-from=./node_modules/cordova-app-hello-world. > >> > > >> > This also implies we can remove our last use of lazy_load from > >> cordova-lib > >> > (minus explicit git clones or platforms/plugins), and npm all the > >> things! > >> > > >> > It also means a semver MAJOR change to cordova-lib that > >> > downstreams directly using cordova-lib's create will need to adjust to. > >> > > >> > Thoughts? > >> > > >> > -Michal > >> > > >> > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
