+1 for this improvement to createmobilespec.js. As Josh pointed out, createmobilespec.js was testing plugin dependencies as a side effect of its implementation detail. In fact, there was no specific asserts or validation done to ensure that the plugin dependency feature worked.
Tests for plugin dependency should be tackled separately and designed purposefully. Thanks, Nikhil -----Original Message----- From: Josh Soref [mailto:[email protected]] Sent: Wednesday, March 18, 2015 8:36 AM To: [email protected] Subject: RE: (Mobile spec) Replace dependency plugin with plugin list parameter in createmobilespec One disadvantage of this is that it means plugin dependencies aren't necessarily tested by most cordova developers. The BlackBerry 10 default plugin system includes a couple of dependencies, and plugin management has had a tendency to be fairly fragile/broken. I'm not opposed to going this way, but if we do, then I'd request that there be a dummy plugin with a dependency (actually, probably with a grand-dependent too) just for the purposes of ensuring that default testing covers these cases. > -----Original Message----- > From: Alexander Sorokin (Akvelon) [mailto:[email protected]] > Sent: Wednesday, March 18, 2015 7:54 AM > To: [email protected] > Subject: (Mobile spec) Replace dependency plugin with plugin list parameter > in createmobilespec > > Hi guys, > > I would like to introduce a little improvement for mobile spec. > > Currently createmobilespec uses dependency plugin to specify the list of > plugins to install. This approach has some limitations, for example after the > app is created the user cannot remove particular plugin because they all are > listed as dependencies of dependency plugin. > > Developers may want to add custom plugin(s) to mobile spec for testing. Also > some plugins could not be supported under particular platform and should > not be installed. > > I've replaced dependency plugin with new command line parameter for > createmobilespec to specify plugin list through CLI. If the parameter is not > passed, createmobilespec will use default list of plugins. > > This change would affect anyone who uses dependency plugin, though, so I > ask a community to review my PR: > https://github.com/apache/cordova-mobile-spec/pull/123/files > > Thanks, > Alexander Sorokin --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
