The tag did get pushed. https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=summary. For some reason it hasn't gotten mirrored to github yet.
I'm not sure what is going on here in regards to the node_modules directory. Even when I did rm -rf node_modules + npm install and then create archive, it is being included in the tgz. Looks like it might be happening because it is listed as a bundled dependency. I'll have to look into it more. On Fri, Aug 7, 2015 at 5:40 PM, Carlos Santana <[email protected]> wrote: > -1 > > > tag 3.9.1 is not push but I was able to get far in verification using > hash d98128682c3cd6a9f51948c7cd6c0d6add2eab44 > > But I got block when trying to create-archive > > I was not able to reproduce tgz using a clean git clone and using $ > ./cordova-coho/coho create-archive -r ios --dest testiosrelease/ --tag > d98128682c3cd6a9f51948c7cd6c0d6add2eab44 > > the tgz in cordova-ios-3.9.1.tgz > < > https://dist.apache.org/repos/dist/dev/cordova/CB-9463/cordova-ios-3.9.1.tgz > > > > Has an extra "node_modules" at the root (node_modules/shelljs/) this is not > present in the repo, and is not present in older tgz 3.9.0 and 3.8.0 > cordova-ios-3.9.0.tgz > <http://archive.apache.org/dist/cordova/platforms/cordova-ios-3.9.0.tgz> > cordova-ios-3.8.0.tgz > <http://archive.apache.org/dist/cordova/platforms/cordova-ios-3.8.0.tgz> > > Not sure if these deserves a -1 but Steve, if you do a clean git clone from > apache git cordova-ios and create-archive you should not get this > "node_modules" at the root of the package tgz > > if you do then I did a step trying to create-archive > > > > > On Fri, Aug 7, 2015 at 5:30 PM Steven Gill <[email protected]> wrote: > > > bump > > > > On Wed, Aug 5, 2015 at 3:59 PM, Steven Gill <[email protected]> > > wrote: > > > > > Please review and vote on this 3.9.1 iOS Release > > > by replying to this email (and keep discussion on the DISCUSS Upcoming > > Releases thread) > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-9463 > > > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/CB-9463 > > > > > > The package was published from its corresponding git tag: > > > cordova-ios: 3.9.1 (d98128682c) > > > > > > Note that you can test it out via: > > > > > > cordova platform add https://github.com/apache/cordova-ios#3.9.1 > > > > > > Upon a successful vote I will upload the archive to dist/, publish it > to > > NPM, and announce it. > > > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > > * Updated [email protected] project to 3.9.1 and ensured that it built. > > > > > > > > >
