Github user njleonzhang commented on the pull request:

    
https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-173780749
  
    @daserge, I don't think this will cause memory leak. In addition, it 
doesn't make sense to hide the splash, if you have  disabled 
AutoHideSplashScreen. 
    
    For example, when an application init, it try to access the network, if the 
network is shutdown, application may pop a alert to ask user to check network 
config and then click retry button in the dialog. This is a popular normal 
scenario. In this situation, user switch the application to background, and 
turn on the wifi, then switch back to our application. They will find the 
splash is closed........ at this moment, the App is not inited, so it may be a 
white screen with a pop up alert dialog. surprise? 
    
    If you think this code change may cause memory leak, I think we should 
involve some expert to review the code. 
    If it do cause memory leak, we should provide another solution for this 
issue.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to