Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/420#discussion_r59018183
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, 
opts) {
     
                                 if (missingVariables.length) {
                                     shell.rm('-rf', pluginInfo.dir);
    +                                events.emit('verbose', 'Removing ' + 
pluginInfo.dir + ' due to installation failure');
                                     var msg = 'Variable(s) missing (use: 
--variable ' + missingVariables.join('=value --variable ') + '=value).';
    --- End diff --
    
    Not sure if i understand you correctly. The `events.emit` at L160 is added 
because the reporter was confused by the abscence of plugin inside of 
`<project>/plugins` directory so i think it'd be better if we clarify that 
we've removed that.
    
    The missing variable is a part of error message and is logged by caller 
code as a part of rejection handling (on particular in 
[restore-utilL127](https://github.com/apache/cordova-lib/pull/420/files#diff-e9221ac2a69074d78c7fb9a8e6b9d4d6R127))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to