Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59039160
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
if (missingVariables.length) {
shell.rm('-rf', pluginInfo.dir);
+ events.emit('verbose', 'Removing ' +
pluginInfo.dir + ' due to installation failure');
var msg = 'Variable(s) missing (use:
--variable ' + missingVariables.join('=value --variable ') + '=value).';
--- End diff --
I now see what you mean. Could you please move the ```events.emit('Removing
...')``` to L159 right before the removal actually occurs ? I hadn't notice
that and got confused.
I think we should also emit a message about the variables
missing.(```events.emit(msg)```)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
