Github user ktop commented on the pull request:

    https://github.com/apache/cordova-lib/pull/432#issuecomment-217972581
  
    @macdonst I've added the implementation for config-file to config.xml just 
to get it working, but I do think it should be refactored 
(cordova-common/src/ConfigChanges/ConfigChanges.js). I really just wanted to 
rename `add_plugin_changes` to something more general but that would mean I 
have to do refactoring in several other repos. I'll take some suggestions on 
how to refactor, but for now, I just made a similar function that does almost 
the same thing, `add_config_changes`. 
    
    This config-file will be handled right after platform prepare happens, 
which is called on every prepare and plugin install/uninstall. I think this 
should handle the case for config.xml overriding plugin.xml. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to