Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-218808479
Other CLIs that use lib (as a lib) would not want this code. Off by default
is interesting, but I think this is cleaner, and it's done.
> On May 12, 2016, at 3:12 AM, Carlos Santana <[email protected]>
wrote:
>
> I have one question, maybe I missed it in discussion why is this
implemented in CLI and not LIB
>
> I think it make more sense to implement in the top level of API entry
points in LIB like create platform plugin etc.
>
> In LIB will be disable by default
> CLI will call API with new parameter to enable telemetry
> CLI telemetry will
> Be enable by default and CLI will offer user a CLI flag and env to
disable telemetry
>
> â
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
