We have a lot of plugin.xml elements that depend on the old file structure. Tags like config-file, source-file, resource-file, etc. all have target elements that take arbitrary paths to project files. Looking at the new project structure, it seems like most of the relevant folders have moved around. Does your proposal handle that or do plugins need to update to reflect the new structure? I figure there isn't much we can do for plugins that use hooks.
Richard -----Original Message----- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Tuesday, May 17, 2016 2:07 PM To: dev <dev@cordova.apache.org> Subject: Re: Proposal: Change Android Project Directory Structure to Android Studio style On Tue, May 17, 2016 at 2:01 PM, Parashuram N <panar...@microsoft.com> wrote: > I think the proposal is great. Our gradle is pretty big, and it does > make sense to just do the defaults. > +1 (personally speaking) to this – will save soo much of my time as I > depend on this for my react-native-cordova-plugin adapter. Your > changes will make life so much easier ☺ > > How do the plugins break? Will plugins have to make change? In a way, > it may make sense to do this with big changes at Google I/O – that > way, we just have 1 breaking change, and plugin authors have to look > at the changes just once. > Ideally they shouldn't break, but I can't guarantee that. I do have to change how plugins are installed in the Android cordova scripts, but the cordova-common work abstracted all that out and made that easier. A user who hasn't tweaked their app shouldn't notice the difference. That said, the users who have may notice stuff, and I have no idea how Crosswalk would work with this yet. It'd be good to work with them once we have something more working. > > On 5/17/16, 1:55 PM, "Joe Bowser" <bows...@gmail.com> wrote: > > >Hey > > > >I know people have been waiting for this for a very long time, but I > >wrote up a proposal to change the project so it's an Android Studio project. > >Given that Android Studio is on 2.1.1, I think it's time we moved > >forward and changed things around. > > > >Proposal PR is here: > >https://github.com/cordova/cordova-discuss/pull/45 > > > >Branch where Proof of Concept work is being done is here: > >https://github.com/infil00p/cordova-android/tree/studio_project_struc > >ture > > > >The main roadblock to doing this, of course is migration of plugins > >and custom code, as well as assets, but I think Android developers > >would welcome this change because we're acting more like a regular, > >normal Android project again and not some old, weird legacy/special case > >thing. > >I've already did some exploratory work with the old > >cordova-android-studio version of cordova-common, and installing > >plugins works fine depending on what version of Cordova you're using. > > > >The other thing that has me stuck is all the functionality in the > >gradle files. I would love to rip out a lot of the stuff we > >autogenerate in there, such as the settings.gradle file that caused > >me a huge headache earlier today when I tried to get importing to > >work. It'd also be good to have a documented process on how we set > >the Application ID, since I can't quite figure out how we do that, > >and I know other people are struggling with that as well. > > > >This would be slated for Cordova-Android 6.0, and hopefully Google IO > >doesn't have too many surprises that break us. > > > >Joe > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
