Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r91953513 --- Diff: appium-tests/common/common.spec.js --- @@ -242,7 +248,6 @@ describe('Contacts Android', function () { describe('Picking contacts', function () { afterEach(function (done) { - checkSession(done); --- End diff -- I don't think this function provides much benefit: it only checks if the first, "self-check"-like test finished properly. If the appium session fails to initiate, the other tests will most certainly fail anyways. In my opinion, it is added complexity. Let me pose the reverse question to you: why have this check?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org