Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92108886 --- Diff: appium-tests/common/common.spec.js --- @@ -228,11 +228,18 @@ describe('Contacts Android', function () { function checkSession(done) { if (failedToStart) { fail('Failed to start a session'); - done(); } + done(); --- End diff -- I think you're still missing the purpose of this check ð The way you put it, it wouldn't work as intended because it wouldn't skip the spec if called from beforeEach, it basically would check the variable and then call `beforeEach`'s `done()`. Then the spec would try to execute anyways. The intent of this check is to skip the spec if the session is failed to start. We could also intentionally call `fail()` here to mark the spec as failed.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org