Comments on the PR are good for a line-by-line. This e-mail thread is basically to decide whether to go ahead with the release process, which is indicated in excruciating detail here:
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md I'll be merging this in tomorrow morning (was going to be later today, but I don't like merging when the CI isn't green) and anyone who is pulling directly from master should be seeing these changes. On Tue, Nov 28, 2017 at 2:15 PM, Jan Piotrowski <piotrow...@gmail.com> wrote: > Thanks Darryl, seems I scrolled over the comments a bit too fast . > > Just installed locally with cordova 7.1.0 and seems to work fine! > > > Here is a Github repo with what I did: > https://github.com/janpio/cordova-android7test > > > There are two branches you can compare: > https://github.com/janpio/cordova-android7test/compare/ > cordova-android@6.4.0...cordova-android@7.0.0 > which only shows _how much_ changed and a direct comparison is useless. > > Better to compare visually by going through the folder structure: > https://github.com/janpio/cordova-android7test/tree/ > cordova-android%406.4.0/platforms/android > https://github.com/janpio/cordova-android7test/tree/ > cordova-android%407.0.0/platforms/android > > > APKs seems to be _much_ smaller now: > https://github.com/janpio/cordova-android7test/blob/ > cordova-android%406.4.0_with_build/platforms/android/build/ > outputs/apk/debug/android-debug.apk > vs. > https://github.com/janpio/cordova-android7test/blob/ > cordova-android%406.4.0_with_build/platforms/android/build/ > outputs/apk/debug/android-debug.apk > Unzipping the APKs shows that mainly the content of /res is much > smaller now and cordova.js contains another > PLATFORM_VERSION_BUILD_LABEL - everything else is identical. > > > Android Studio is happy with the project and can build it via Gradle. > It also shows the Manifest file in the default view now as the > structure is recognized. > > > Really nice how painless testing this was. Thanks Joe. > > Questions and feedback here on the list or better as comments in the PR? > > -J > > 2017-11-28 21:43 GMT+01:00 Darryl Pogue <dvpdin...@gmail.com>: > > The steps here should work: > > https://github.com/apache/cordova-android/pull/389# > issuecomment-320067936 > > > > To recap on email, you'll want to add the android platform via a git > reference: > > > > cordova platform add > > git://github.com/infil00p/cordova-android.git#StudioProjectCompat > > > > On Tue, Nov 28, 2017 at 12:24 PM, Jan Piotrowski <piotrow...@gmail.com> > wrote: > >> > >> Awesome! > >> > >> For reference, you are talking about > >> https://github.com/apache/cordova-android/pull/389, correct? > >> > >> What can I / one do to test this locally? > >> > >> -J > >> > >> 2017-11-28 19:53 GMT+01:00 Joe Bowser <bows...@gmail.com>: > >> > Hey > >> > > >> > I'm going to merge in StudioProjectCompat into Master today. Once > that's > >> > done, I'd like to get the next major version of Cordova out so that > there's > >> > not a crazy difference between master and the released versions of > >> > Cordova. This release will have the new structure for Android Studio > >> > projects, which in the future will be easier to maintain, and will > allow > >> > for people to experiment with writing Cordova Android plugins in > Koltin. (I > >> > haven't tried, because I need this to land before I can do that). > >> > > >> > I've wrapped up all the PRs on cordova-android except for that one, > and > >> > I've put everything up until this point in 6.4.x as well, since 6.4.0 > will > >> > be the last 6.x version before this release comes out. > >> > > >> > As far as Crosswalk, this does once again break Crosswalk, but > Crosswalk > >> > has been discontinued by the original maintainers. That said, in > theory > >> > once the fix is made in the Crosswalk repo, it should in theory be > able to > >> > work with the new structure. > >> > > >> > Also, this release will be bumping up the supported API Version to > Android > >> > 4.4, or API Level 19. > >> > > >> > This will hopefully be the last major release of Cordova Android, but > it > >> > comes with a LOT of much needed updates and fixes (i.e. Adopting Java > 8). > >> > If this doesn't get released, we're going to forever be bogged down > with > >> > legacy code. It's been extremely hard to get as much feedback on > this one, > >> > so more feedback is appreciated. > >> > > >> > Thanks > >> > > >> > Joe > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
