Thanks Joe and Darryl, makes sense and sounds good.

I'm looking forward to the merge and getting some more eyeballs (and
projects with all their different plugins...) on it. Having a "modern"
project structure is really great.

-J

2017-11-29 1:36 GMT+01:00 Darryl Pogue <dvpdin...@gmail.com>:
> I believe we can do published beta or rc builds, so long as they are
> considered releases and follow the usual rules for a published
> release. They would be releases, but with a -beta.1 or -rc.1 suffix on
> the version number.
>
> We probably don't have to do that through: As Joe says, it's a major
> version bump and existing projects will not automatically upgrade.
> Versions that are saved into config.xml or package.json automatically
> use ^ or ~ restrictions to ensure that major version bumps will not
> happen without manual intervention.
>
> One thing to be aware of though is that cordova-cli (or one of its
> dependencies) has an internal list of "compatible" versions and will
> install those versions by default. So even if we published v7.0.0 next
> week, end users would need to specifically ask for it until the CLI
> has been updated and published.
>
>
> Release details aside, I did a quick test of the PR with my latest
> project (albeit with no plugins) and it all seemed to work. One thing
> that we'll need to mention in docs/blog is that resource-file and
> edit-config tags in config.xml will need to be updated to the new
> paths.
>
> On Tue, Nov 28, 2017 at 4:26 PM, Joe Bowser <bows...@gmail.com> wrote:
>> On Tue, Nov 28, 2017 at 3:35 PM, Jan Piotrowski <piotrow...@gmail.com>
>> wrote:
>>
>>> Is there any "beta" release process defined (7.0.0-beta?) that could
>>> be used to get more feedback? Maybe create a blog post with
>>> instructions on how to test this beta version?
>>> I can't even imagine all the variations on how people out there are
>>> using all this and what could go wrong.
>>>
>>>
>> There's no beta release process.  The official release is the official
>> release, and we test it the best we can and send it out to the world after
>> a series of release candidates, all of which happens out in the open.  The
>> ASF release process in it's entirety is here, which includes the discussion
>> about dev builds:
>>
>> http://www.apache.org/legal/release-policy.html
>>
>> In addition to that, we currently do our best to adhere to semver to
>> indicate what sort of release we're trying to do.
>>
>> https://semver.org/
>>
>> It's this adherence to semver that kept a bunch of these PRs sitting around
>> in the GitHub repo for way too damn long (a lot of those old PRs were from
>> July and August!), because we need to keep master ready for a security
>> release.  The fact that we're releasing a Cordova-Android 7.0.0 is an
>> indication that things will break.  People are under no obligation to
>> immediately upgrade their existing codebases to this, many third party
>> plugins will most likely break in the short term, and technically we're
>> supposed to be supporting 6.4.x for six months after this release, although
>> that's contingent on active contributors (we need people to own processes).
>>
>> The last major Cordova-Android release was 6.0.0, back in October 2016,
>> when we changed the default bridge.  A more accurate example of a major
>> release would be Cordova-Android 5.0.0, when permissions were brought in,
>> or Cordova-Android 4.0.0, when we first added support for Crosswalk and
>> other Third Party WebViews. (i.e. GeckoView, tencent, etc).  We try and
>> only do a major release annually, and given the fact that Android Studio is
>> an unstable moving target, this was sorely needed.
>>
>> I'm going to merge in the PR tomorrow morning and see how many people are
>> watching master and not the list.
>>
>> -J
>>>
>>>
>>> 2017-11-29 0:03 GMT+01:00 Joe Bowser <bows...@gmail.com>:
>>> > Comments on the PR are good for a line-by-line.  This e-mail thread is
>>> > basically to decide whether to go ahead with the release process, which
>>> is
>>> > indicated in excruciating detail here:
>>> >
>>> > https://github.com/apache/cordova-coho/blob/master/docs/
>>> platforms-release-process.md
>>> >
>>> > I'll be merging this in tomorrow morning (was going to be later today,
>>> but
>>> > I don't like merging when the CI isn't green) and anyone who is pulling
>>> > directly from master should be seeing these changes.
>>> >
>>> > On Tue, Nov 28, 2017 at 2:15 PM, Jan Piotrowski <piotrow...@gmail.com>
>>> > wrote:
>>> >
>>> >> Thanks Darryl, seems I scrolled over the comments a bit too fast .
>>> >>
>>> >> Just installed locally with cordova 7.1.0 and seems to work fine!
>>> >>
>>> >>
>>> >> Here is a Github repo with what I did:
>>> >> https://github.com/janpio/cordova-android7test
>>> >>
>>> >>
>>> >> There are two branches you can compare:
>>> >> https://github.com/janpio/cordova-android7test/compare/
>>> >> cordova-android@6.4.0...cordova-android@7.0.0
>>> >> which only shows _how much_ changed and a direct comparison is useless.
>>> >>
>>> >> Better to compare visually by going through the folder structure:
>>> >> https://github.com/janpio/cordova-android7test/tree/
>>> >> cordova-android%406.4.0/platforms/android
>>> >> https://github.com/janpio/cordova-android7test/tree/
>>> >> cordova-android%407.0.0/platforms/android
>>> >>
>>> >>
>>> >> APKs seems to be _much_ smaller now:
>>> >> https://github.com/janpio/cordova-android7test/blob/
>>> >> cordova-android%406.4.0_with_build/platforms/android/build/
>>> >> outputs/apk/debug/android-debug.apk
>>> >> vs.
>>> >> https://github.com/janpio/cordova-android7test/blob/
>>> >> cordova-android%406.4.0_with_build/platforms/android/build/
>>> >> outputs/apk/debug/android-debug.apk
>>> >> Unzipping the APKs shows that mainly the content of /res is much
>>> >> smaller now and cordova.js contains another
>>> >> PLATFORM_VERSION_BUILD_LABEL - everything else is identical.
>>> >>
>>> >>
>>> >> Android Studio is happy with the project and can build it via Gradle.
>>> >> It also shows the Manifest file in the default view now as the
>>> >> structure is recognized.
>>> >>
>>> >>
>>> >> Really nice how painless testing this was. Thanks Joe.
>>> >>
>>> >> Questions and feedback here on the list or better as comments in the PR?
>>> >>
>>> >> -J
>>> >>
>>> >> 2017-11-28 21:43 GMT+01:00 Darryl Pogue <dvpdin...@gmail.com>:
>>> >> > The steps here should work:
>>> >> > https://github.com/apache/cordova-android/pull/389#
>>> >> issuecomment-320067936
>>> >> >
>>> >> > To recap on email, you'll want to add the android platform via a git
>>> >> reference:
>>> >> >
>>> >> >     cordova platform add
>>> >> > git://github.com/infil00p/cordova-android.git#StudioProjectCompat
>>> >> >
>>> >> > On Tue, Nov 28, 2017 at 12:24 PM, Jan Piotrowski <
>>> piotrow...@gmail.com>
>>> >> wrote:
>>> >> >>
>>> >> >> Awesome!
>>> >> >>
>>> >> >> For reference, you are talking about
>>> >> >> https://github.com/apache/cordova-android/pull/389, correct?
>>> >> >>
>>> >> >> What can I / one do to test this locally?
>>> >> >>
>>> >> >> -J
>>> >> >>
>>> >> >> 2017-11-28 19:53 GMT+01:00 Joe Bowser <bows...@gmail.com>:
>>> >> >> > Hey
>>> >> >> >
>>> >> >> > I'm going to merge in StudioProjectCompat into Master today.  Once
>>> >> that's
>>> >> >> > done, I'd like to get the next major version of Cordova out so that
>>> >> there's
>>> >> >> > not a crazy difference between master and the released versions of
>>> >> >> > Cordova.  This release will have the new structure for Android
>>> Studio
>>> >> >> > projects, which in the future will be easier to maintain, and will
>>> >> allow
>>> >> >> > for people to experiment with writing Cordova Android plugins in
>>> >> Koltin. (I
>>> >> >> > haven't tried, because I need this to land before I can do that).
>>> >> >> >
>>> >> >> > I've wrapped up all the PRs on cordova-android  except for that
>>> one,
>>> >> and
>>> >> >> > I've put everything up until this point in 6.4.x as well, since
>>> 6.4.0
>>> >> will
>>> >> >> > be the last 6.x version before this release comes out.
>>> >> >> >
>>> >> >> > As far as Crosswalk, this does once again break Crosswalk, but
>>> >> Crosswalk
>>> >> >> > has been discontinued by the original maintainers.  That said, in
>>> >> theory
>>> >> >> > once the fix is made in the Crosswalk repo, it should in theory be
>>> >> able to
>>> >> >> > work with the new structure.
>>> >> >> >
>>> >> >> > Also, this release will be bumping up the supported API Version to
>>> >> Android
>>> >> >> > 4.4, or API Level 19.
>>> >> >> >
>>> >> >> > This will hopefully be the last major release of Cordova Android,
>>> but
>>> >> it
>>> >> >> > comes with a LOT of much needed updates and fixes (i.e. Adopting
>>> Java
>>> >> 8).
>>> >> >> > If this doesn't get released, we're going to forever be bogged down
>>> >> with
>>> >> >> > legacy code.  It's been extremely hard to get as much feedback on
>>> >> this one,
>>> >> >> > so more feedback is appreciated.
>>> >> >> >
>>> >> >> > Thanks
>>> >> >> >
>>> >> >> > Joe
>>> >> >>
>>> >> >> ------------------------------------------------------------
>>> ---------
>>> >> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> >> >> For additional commands, e-mail: dev-h...@cordova.apache.org
>>> >> >>
>>> >> >
>>> >> > ---------------------------------------------------------------------
>>> >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> >> > For additional commands, e-mail: dev-h...@cordova.apache.org
>>> >> >
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> >> For additional commands, e-mail: dev-h...@cordova.apache.org
>>> >>
>>> >>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to