On Tue, Aug 7, 2018 at 12:36 PM Chris Brody <chris.br...@gmail.com> wrote: > > > I would suggest we use something similar to this, which explicitly > > asks for running the tests and writing documentation: > > https://github.com/fastlane/fastlane/blob/master/.github/PULL_REQUEST_TEMPLATE.md > > > > What do you think regarding PR template? > > Looks nice in general, again we should probably give proper > attribution upon reuse. > > It might be good to require a checkbox for developers certificate of > origin (developercertificate.org) like at: > https://github.com/papercss/papercss/blob/master/.github/PULL_REQUEST_TEMPLATE.md
If we were going to require something like this, I think we would have to go back to the ASF ICLA again. We had finally moved away from requiring that for pull requests using the act of opening a pull request as intent to contribute, but previously it was required to all PRs and there were a bunch of people who never signed it leading to PRs with valid bugfixes staying open and getting stale because we weren't allowed to merge them for policy reasons. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
