I support the proposal to do a release for the iOS 13 fix before doing this change.
For refrence this is the thread about a new IAB release: https://lists.apache.org/thread.html/9cf042a3a62fcad899a18759ed40a72087bfafd6cfe6dd48e77f61d1@%3Cdev.cordova.apache.org%3E From: "julio cesar sanchez" <jcesarmob...@gmail.com> To: "dev@cordova.apache.org" <dev@cordova.apache.org> Date: 02.12.2019 01:19 Subject: Re: [DISCUSS] Cordova-iOS 5.1.1 Patch Release That should be a separate discussion. But basically that preference is for people not using UIWebView, if they or their plugins are using it it won’t work, that’s expected. In plugins I would rather remove the whole UIWebView code than adding the conditional compile option, I already sent a pr that removes it long ago. But I think we should do a release first before merging that breaking change, since at the moment, latest released version of InAppBrowser doesn’t work on iOS 13 if using WKWebView option and has been fixed for a few weeks in master. (There is already a thread proposing the release) El domingo, 1 de diciembre de 2019, Tim Brust <tim.br...@sinnerschrader.com.invalid> escribió: > I'd like to bring attention to the fact, that even with the 5.1.1 release > the cordova-plugin-inappbrowser will need an update, too. > It's already reported that it's not working with cordova-ios 5.1.0 and the > WKWebViewOnly flag enabled. > Issue: https://github.com/apache/cordova-plugin-inappbrowser/issues/583, > potential PR: > https://github.com/apache/cordova-plugin-inappbrowser/issues/584 > > On Thu, Nov 28, 2019 at 1:47 PM Bryan Ellis <ellis.br...@gmail.com> wrote: > > > Correction: > > > > The current changes link is written correctly but hyperlink is incorrect. > > Here is the correct link. > > > > https://github.com/apache/cordova-ios/compare/rel/5.1.0...master > > > > Please also note that the 5.2.0-dev related commits will not be > > cherry-picked into the 5.1.x branch or in the 5.1.1 release. > > > > On Thu, Nov 28, 2019 at 10:05 PM Bryan Ellis <er...@apache.org> wrote: > > > > > Does anyone have any reason to delay a cordova-ios patch release > (5.1.1)? > > > > > > Any outstanding patches to land? > > > > > > Current changes: > > > https://github.com/apache/cordova-ios/compare/rel/5.1.0...master > > > <https://github.com/apache/cordova-ios/compare/rel/5.0.1...master> > > > > > > As a bug was introduced in the minor release, I will go ahead and > submit > > > the vote shortly to get a quick turnaround on the patch release. > > > > > > > > -- > Tim Brust, Product Engineer > > tim.br...@sinnerschrader.com > T +49 40 398855 315 > > SinnerSchrader Deutschland GmbH | SinnerSchrader Group > Völckersstraße 38, 22765 Hamburg, Germany > > Amtsgericht Hamburg HRB-Nr. 63663 > Geschäftsführer: Matthias Schrader (Sprecher), > Jürgen Alker, Dr. Axel Averdung, Holger Blank, > Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson > > Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag > > https://www.sinnerschrader.com | NEXT AGENCY > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
