I've done that in all needed repos. Now, I'm running through the PR checklist and am getting stuck especially on the tests: https://cordova.apache.org/contribute/contribute_guidelines.html
Cordova-browser doesn't seem to have a test for the "run" command in the /spec directory; it only tests to confirm that the command exists in the installation. Thanks, ___ Michael Gatto · Senior Software Engineer · vinSUITE o: 707-253-7400 e: mga...@vinsuite.com vinsuite <https://www.vinsuite.com/> · twitter <https://twitter.com/vinsuite>· facebook <https://www.facebook.com/vinSUITEsoftware/>· linkedin <https://www.linkedin.com/company/vinsuite/> You sell wine. We make it easier. Top 5 Tasting Room Survey Takeaways - Watch Now! <https://go.vinsuite.com/watch-CellarPass-webinar> On 7/13/23, 4:38 PM, "Norman Breau" <nor...@nbsolutions.ca> wrote: Hi Michael, Each repo acts independently, so each repo that requires changes will need their own PR. If there are PRs that depend on another PR, then I'd make note of that in the PR with a link to the dependency. Let us know if you have any further questions! Cheers, Norman On 2023-07-13 8:07 p.m., Michael Gatto wrote: > Hi Cordova team, > > I have a series of commits which I want to propose with a PR. The commits are in: > > - cordova-browser, > - cordova-serve, > - cordova-lib, > - cordova-cli. > > How do I reference that? And which repo gets the PR? A top-level one, or each of the above? > > > Thanks, > ___ > Michael Gatto · Senior Software Engineer · vinSUITE > o: 707-253-7400 e: mga...@vinsuite.com<mailto:mga...@vinsuite.com> > vinsuite<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.vinsuite.com%2F&data=05%7C01%7Cmgatto%40vinsuite.com%7C851ebd363ff043aa192308db83fa4c1c%7C15d2a08ce324483fb07608dbe6d901f7%7C0%7C0%7C638248883301654194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TNOcunIpw%2FqMUp1u2K3vJmgfS3K06t8hIBznCtNHYOE%3D&reserved=0> · twitter <https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Fvinsuite&data=05%7C01%7Cmgatto%40vinsuite.com%7C851ebd363ff043aa192308db83fa4c1c%7C15d2a08ce324483fb07608dbe6d901f7%7C0%7C0%7C638248883301654194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BvwOwtSl1fTgBsn4S3gLmUiK%2FtWGMmqWB86NuKurNQ8%3D&reserved=0> · facebook <https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.facebook.com%2FvinSUITEsoftware%2F&data=05%7C01%7Cmgatto%40vinsuite.com%7C851ebd363ff043aa192308db83fa4c1c%7C15d2a08ce324483fb07608dbe6d901f7%7C0%7C0%7C638248883301654194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kzI24E2jcnZpQSYAiP66PbhexzpM4I8iLJAf%2FYgJm0A%3D&reserved=0> · linkedin<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.linkedin.com%2Fcompany%2Fvinsuite%2F&data=05%7C01%7Cmgatto%40vinsuite.com%7C851ebd363ff043aa192308db83fa4c1c%7C15d2a08ce324483fb07608dbe6d901f7%7C0%7C0%7C638248883301654194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=06fem%2FxKFqBjIEGDaLtxXWhuJQiQMNKCMmfu2vzX1yM%3D&reserved=0> > > You sell wine. We make it easier. > Top 5 Tasting Room Survey Takeaways - Watch Now!<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgo.vinsuite.com%2Fwatch-CellarPass-webinar&data=05%7C01%7Cmgatto%40vinsuite.com%7C851ebd363ff043aa192308db83fa4c1c%7C15d2a08ce324483fb07608dbe6d901f7%7C0%7C0%7C638248883301654194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2B36hBEHiWR9YXq0UpcT7X8iFGJzd53dtiV7P3y4Cj6E%3D&reserved=0> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
