On 9 August 2015 at 19:42, Dennis E. Hamilton <[email protected]> wrote:
> The exclusion of build-tool artifacts is more a safeguard against > developers doing IDE editing and testing in the tree in inappropriate > places, just like the "~" case but more serious. > a lot more serious....e.g. a .sln file can only be there if you ask cmake to generate it. > > I eliminated those likely suspects because GitHub has found it important. > I included it in .gitignore as a precautionary reminder. I did not bring > back in all other cases. But I know Visual Studio builds are sort of > encouraged for Windows. > > I am not attached to doing that. It does strike me as harmless though. > I feel strongly about it, because you supress a signal that the system is being build wrongly. Visual studio uses the sln directory (and subdirs) for all its files (with our current cmake), so it is a real error if we see them elsewhere, something the developer should see and not be silently ignored. I read peter as also being against having them in .gitignore, so if you are not attached to it, please revert that part (together with iconv.txt). rgds jan i. > - Dennis > > PS: I removed the external/* entry. > > > > -----Original Message----- > From: Peter Kelly [mailto:[email protected]] > Sent: Sunday, August 9, 2015 09:59 > To: [email protected] > Subject: Re: Release_0.1 > > [ ... ] I’ve just had a look at the latest .gitignore and I think some of > the entries do not belong there. Things like .DS_Store and *~ which would > reasonably exist in the source tree are fine in my opinion, but for example > *.sln, *.vcxproject etc are not, since they are supposed to be inside other > directories. On my setup I have a “build” (for OS X) and “winbuild” (for > Windows) directories (on my Linux VM I use a separate dir); these just show > up as “untracked files” which do not cause problems. > > Visual studio files, XCode project files, Makefiles etc. are not supposed > to go in any source directories other than a custom “build” (or > similarly-named) directory if you want (you can also do it outside of the > tree). > > As Jan mentioned, external is dead now as we’re using a pre-built zip file > of all the libraries. > > — > Dr Peter M. Kelly > [email protected] > > PGP key: http://www.kellypmk.net/pgp-key <http://www.kellypmk.net/pgp-key> > (fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966) > > >
