[ 
https://issues.apache.org/jira/browse/COUCHDB-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980410#action_12980410
 ] 

Paul Joseph Davis commented on COUCHDB-562:
-------------------------------------------

That looks good to me.

The part that irritated me was that it only sets them when unset. Not the 
implicit set part.

For the cleanup of flag leaking, I think we should add that but it'd probably 
be best as its own patch and more thorough to keep erlang stuff off the js 
build and what not.

> link couchjs with bound libmozjs
> --------------------------------
>
>                 Key: COUCHDB-562
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-562
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 0.11
>         Environment: linux, ubuntu,debian
>            Reporter: Meno Abels
>             Fix For: 1.2
>
>         Attachments: couchdb-562.patch, couchdb-562_2.patch, 
> couchdb-562_3.patch, couchdb-mozjs-rpath.patch
>
>
> If you build the couchdb from the source with a prefix set and 
> --with-js-[lib|include] option the resulting couchjs programm in 
> <prefix>/lib/couchdb/bin/couchjs does not know where to find the specified 
> libmozjs.so which was specified in with-js-lib. This causes that quite all 
> test will fail. 
> To fix this the rpath has to setup during the compile. I don't had a look 
> where to do this.
> but a small shell wrapper fix it also
> #!/bin/sh
> LD_LIBRARY_PATH=...  exec $0.orig $@

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to