[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109147#comment-13109147 ]
Bob Dionne commented on COUCHDB-1289: ------------------------------------- Good idea Filipe, much as I dislike using the heap, this does make the code simpler[1]. Still need the boolean `changes_sent` in the `changes_acc` to know something actually got sent, but it's better [1] https://github.com/bdionne/couchdb/commit/8b2bf85fcade > heartbeats skipped when continuous changes feed filter function produces no > results > ----------------------------------------------------------------------------------- > > Key: COUCHDB-1289 > URL: https://issues.apache.org/jira/browse/COUCHDB-1289 > Project: CouchDB > Issue Type: Bug > Components: Database Core > Reporter: Bob Dionne > Assignee: Bob Dionne > Priority: Minor > > if the changes feed has a filter function that produces no results, > db_updated messages will still be sent and the heartbeat timeout will never > be reached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira