[
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155811#comment-13155811
]
Filipe Manana commented on COUCHDB-1289:
----------------------------------------
Bob, np.
Looking at the whole context, not limited to see only the diff, I think you're
right. The patch addresses the case I mentioned before, since it each tree fold
has changes_sent set to false for initial accumulator and the
changes_enumerator callback sets it to true once a row is accepted by the
filter. However this is set only for the "continuous" clause of
changes_enumerator. The other clause should set changes_set to true according
to the same condition.
> heartbeats skipped when continuous changes feed filter function produces no
> results
> -----------------------------------------------------------------------------------
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Assignee: Bob Dionne
> Priority: Minor
> Attachments:
> 0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch
>
>
> if the changes feed has a filter function that produces no results,
> db_updated messages will still be sent and the heartbeat timeout will never
> be reached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
