Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/434#discussion_r31172077
--- Diff: app/addons/dashboard/stores.js ---
@@ -0,0 +1,169 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use this file except in compliance with the License. You may obtain a
copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+
+define([
+ 'app',
+ 'api',
+ 'addons/activetasks/actiontypes'
+], function (app, FauxtonAPI, ActionTypes) {
+
+ var DashboardStore = FauxtonAPI.Store.extend({
+
+ init: function (collectionTable, backboneCollection) {
+ this._prevSortbyHeader = 'started_on';
+ this._headerIsAscending = true;
+ this._selectedRadio = 'All Tasks';
+ this._sortByHeader = 'started_on';
+ this._searchTerm = '';
+ this._collection = collectionTable;
+ this._pollingIntervalSeconds = 5;
+ this.sortCollectionByColumnHeader(this._sortByHeader);
+ this._backboneCollection = backboneCollection;
+ },
+
+ getSelectedRadio: function () {
+ return this._selectedRadio;
+ },
+
+ setSelectedRadio: function (selectedRadio) {
+ this._selectedRadio = selectedRadio;
+ },
+
+ getPollingInterval: function () {
+ return this._pollingIntervalSeconds;
+ },
+
+ setPollingInterval: function (pollingInterval) {
+ this._pollingIntervalSeconds = pollingInterval;
+ },
+
+ setPolling: function () {
+ clearInterval(this.getIntervalID());
+ var id = setInterval(function () {
+ this._backboneCollection.pollingFetch();
+ this.setCollection(this._backboneCollection.table);
+ this.sortCollectionByColumnHeader(this._prevSortbyHeader, false);
+ this.triggerChange();
+ }.bind(this), this.getPollingInterval() * 1000);
+
+ this.setIntervalID(id);
+ },
+
+ clearPolling: function () {
+ clearInterval(this.getIntervalID());
+ },
+
+ getIntervalID: function () {
+ return this._intervalID;
+ },
+
+ setIntervalID: function (id) {
+ this._intervalID = id;
+ },
+
+ setCollection: function (collection) {
+ this._collection = collection;
+ },
+
+ getCollection: function () {
+ return this._collection;
+ },
+
+ sortCollectionByColumnHeader: function (colName) {
+ var collectionTable = this._collection;
+
+ var sorted = _.sortBy(collectionTable, function (item) {
+ var variable = colName;
+
+ if (_.isUndefined(item[variable])) {
+ variable = 'source';
+ }
+ return item[variable];
+ });
+
+ this._prevSortbyHeader = colName;
+ this._collection = sorted;
+ },
+
+ getFilteredTable: function (collection) {
+ var table = [];
--- End diff --
This is a bit subtle, but I kind of like `map` methods to return something,
rather than construct an array stored outside of it. Again, Michelle + Robert
can pipe up if they disagree.
I'd abbreviate it to something like this (untested):
```javascript
var table = this._collection.filter(function (item) {
return this.passesRadioFilter(item) && this.passesSearchFilter(item);
}, this);
```
If you find the separate vars for the two method calls clearer, leave them
in - your call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
