Thanks for clarifying! Fine then :-) Alessio
Il mer 22 lug 2020, 23:42 Joan Touzet <woh...@apache.org> ha scritto: > We already have the behaviour of line 32. The line: > > pullrequests: notificati...@couchdb.apache.org > > which is not commented out, is the same as saying: > > pullrequests_status: notificati...@couchdb.apache.org > pullrequests_comment: notificati...@couchdb.apache.org > > If people don't want notification of new/closed PRs on dev@, that's > fine, I just thought it might increase visibility. > > -Joan > > On 2020-07-22 5:17 p.m., Alessio 'Blaster' Biancalana wrote: > > Maybe line 32 would be fine. > > > > Having PR status notifications streamed on dev would be noisy I think. > > > > Thanks for bringing this to the table! > > > > Alessio > > > > On Wed, Jul 22, 2020 at 6:45 PM Joan Touzet <woh...@apache.org> wrote: > > > >> We now have a plurality of +1s so I'm going to merge this. > >> > >> On 21/07/2020 18:12, Joan Touzet wrote: > >>>> Please see lines 29-32 of the file. We can also make this change if we > >>>> want - which would send new/closed PR notifications to dev@, while > >>>> sending all comments/etc to notifications@ as we do today. > >> > >> Just a note that while this didn't happen, I'm +1 if someone else wants > >> to file the PR to uncomment those (and comment out line 28.) > >> > >> -Joan > >> > > >
