MATRIX4284 commented on issue #76: Crail Kubernetes Deployment on POD Network with revised docker configuration to acomodate Node Discovery URL: https://github.com/apache/incubator-crail/pull/76#issuecomment-500371335 Hi Adrian, I will remove this python file as it is not getting used by my modules . In fact the new the pull request i created i have removed this file if not i will remove it asap . I have created the two artifacts under deploy folder and changed the crail-site.conf and the slaves where i pointed to my services The python file you mentioned is not getting used by any of my code. I can remove it in next update in case i forgot. Thanks, Kaustav Thanks , Kaustav On Mon, 10 Jun 2019 at 3:57 PM, Adrian Schuepbach <[email protected]> wrote: > *@asqasq* requested changes on this pull request. > ------------------------------ > > In kubernetes/dockerfiles/crail-apache/datanode.py > <https://github.com/apache/incubator-crail/pull/76#discussion_r291958143>: > > > @@ -0,0 +1,84 @@ > +############## Pocket resource utilization daemon #################### > + > +#from jsonsocket import Client > +import time > +import psutil > +import ifcfg > +import threading > +import pickle > +import sys > +import socket > +import struct > + > +CONTROLLER_IP = "10.1.47.178" > > This seems to be a hard-coded IP to me. Why? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-crail/pull/76?email_source=notifications&email_token=AE7YQAGSLAGOOECEMIVJK3TPZYT7PA5CNFSM4HWPT3PKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3AUGWA#pullrequestreview-247546712>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AE7YQAHQZ4N6PGM6NWVTRHTPZYT7PANCNFSM4HWPT3PA> > . > -- *Thanks & Regards,* *Kaustav* *Technical Envagelist* *Embedded & Distributed Systems*
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
