MATRIX4284 commented on issue #76: Crail Kubernetes Deployment on POD Network with revised docker configuration to acomodate Node Discovery URL: https://github.com/apache/incubator-crail/pull/76#issuecomment-500729161 Hi Adrian, Thanks for your feedback . I will close this PR. Thanks Kaustav On Tue, 11 Jun 2019 at 1:16 PM, Adrian Schuepbach <[email protected]> wrote: > Hi Kaustav > > Actually I do understand the flow. > > This PR cannot be merged for several reasons: > > 1. In my opinion it is not the right way to just copy files from other > people and claim that > they are youres (even more, you copied our files from our repositories) > 2. The Pocket files do not work with the latest Crail version. Pocket > was a research project > based on a older and especially a modified version of Crail. > 3. It seems to me that you don't understand what you are doing > 4. I doubt that you tested it, especially after your last change. > Deleting few files > could potentially mean that something does not work anymore (I doubt > that it worked before). > 5. We cannot reference docker images from a non-trusted source in the > yaml files. > > Therefore, we cannot merge this PR. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-crail/pull/76?email_source=notifications&email_token=AE7YQABGGZHOKE5HDIUZ7ILPZ5J5VA5CNFSM4HWPT3PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXMH44A#issuecomment-500727408>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AE7YQAG3BOOBPOCJTF4H65DPZ5J5VANCNFSM4HWPT3PA> > . > -- *Thanks & Regards,* *Kaustav* *Technical Envagelist* *Embedded & Distributed Systems*
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
