[jira] [Commented] (RAT-190) False negatives(?) in apache rat license checking

[Philipp Ottlinger (JIRA)]

    [ 
https://issues.apache.org/jira/browse/RAT-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284533#comment-14284533
 ] 

Philipp Ottlinger commented on RAT-190:
---------------------------------------

Hi Dan,

I'm not really sure about your expectation but your pom seems to miss the 
correct license header.

When I correct the configuration into
{code}
          <licenses>
            <license 
implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
              <licenseFamilyCategory>IBMCL</licenseFamilyCategory>
              <licenseFamilyName>IBM Copyright</licenseFamilyName>
              <notes/>
              <patterns>
                <pattern>Copyright IBM Corp. 2015</pattern>
                <pattern>Copyright IBM Corp. 2014, 2015</pattern>
                <pattern>Copyright IBM Corp. 2013, 2015</pattern>
                <pattern>Copyright IBM Corp. 2014</pattern>
              </patterns>
            </license>
          </licenses> 
{code}
I can run the project with Java8/Mvn3 and do not get any errors with 
apache-rat:check and a plain call to mvn.

Can you verify and/or clarify your expectations?

> False negatives(?) in apache rat license checking
> -------------------------------------------------
>
>                 Key: RAT-190
>                 URL: https://issues.apache.org/jira/browse/RAT-190
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.8, 0.11
>            Reporter: Dan Dumont
>         Attachments: test.zip
>
>
> We're using rat to enforce our internal copyright on all of our source files.
> We're seeing it missing files that should be flagged.  Here's part of our pom:
> <licenses>
>   <license 
> implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
>     <licenseFamilyCategory>IBMCL</licenseFamilyCategory>
>     <licenseFamilyName>IBM Copyright</licenseFamilyName>
>     <notes></notes>
>     <patterns>
>       <pattern>Copyright IBM Corp. 2015</pattern>
>       <pattern>Copyright IBM Corp. 2014, 2015</pattern>
>       <pattern>Copyright IBM Corp. 2013, 2015</pattern>
>     </patterns>
>   </license>
> </licenses>
> <licenseFamilies>
>   <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
>   <familyName>IBM Copyright</familyName>
> </licenseFamily>
> </licenseFamilies>
> The file in question is "included" as reported by running with debug 
> output...  but the file's copyright is:
> /* Copyright IBM Corp. 2014  All Rights Reserved.                    */



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)