Claudenw commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1377861349
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory,
ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
In the new code base (after RAT-321) the ReportConfiguraiton.out is now a
org.apache.commons.io.function.IOSupplier so the output does not get
constructed until it is used and then it is done in the try with resource
closable.
You should be able to rebase and have the "o" option create the IOSupplier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
