Claudenw commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1378464274
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory,
ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
Review Comment:
This line should close the output.
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory,
ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
I see that what you have done is remove the output from the method and let
the exceptions provide the info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
