ottlinger commented on code in PR #233:
URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564253245
##########
apache-rat-core/src/main/java/org/apache/rat/report/claim/ClaimStatistic.java:
##########
@@ -19,100 +19,62 @@
package org.apache.rat.report.claim;
+import java.util.HashMap;
import java.util.Map;
+import org.apache.rat.api.Document;
+
/**
* This class provides a numerical overview about
* the report.
*/
public class ClaimStatistic {
- private Map<String, Integer> documentCategoryMap, licenseFamilyCodeMap,
licenseFamilyNameMap;
- private int numApproved, numUnApproved, numGenerated, numUnknown;
-
- /**
- * @return Returns the number of files with approved licenses.
- */
- public int getNumApproved() {
- return numApproved;
- }
-
- /**
- * Sets the number of files with approved licenses.
- * @param pNumApproved number of files with approved licenses.
- */
- public void setNumApproved(int pNumApproved) {
- numApproved = pNumApproved;
- }
-
- /**
- * @return Returns the number of files with unapproved licenses.
- * <em>Note:</em> This might include files with unknown
- * licenses.
- * @see #getNumUnknown()
- */
- public int getNumUnApproved() {
- return numUnApproved;
- }
-
- /**
- * Sets the number of files with unapproved licenses.
- * @param pNumUnApproved number of files with unapproved licenses.
- */
- public void setNumUnApproved(int pNumUnApproved) {
- numUnApproved = pNumUnApproved;
- }
-
- /**
- * @return Returns the number of generated files.
- */
- public int getNumGenerated() {
- return numGenerated;
- }
+ /** The counter types */
+ public enum Counter {
Review Comment:
Uppercase all enums?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
