ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564221716
########## apache-rat-core/src/main/java/org/apache/rat/document/impl/ArchiveEntryDocument.java: ########## @@ -37,44 +36,44 @@ public class ArchiveEntryDocument implements Document { private final MetaData metaData = new MetaData(); - public ArchiveEntryDocument(File file, byte[] contents) throws RatException { + public ArchiveEntryDocument(File file, byte[] contents) { super(); name = DocumentImplUtils.toName(file); this.contents = contents; } + @Override public MetaData getMetaData() { return metaData; } + @Override public String getName() { return name; } + @Override public InputStream inputStream() throws IOException { return new ByteArrayInputStream(contents); } + @Override public boolean isComposite() { return DocumentImplUtils.isZipStream(new ByteArrayInputStream(contents)); Review Comment: Could we change the interface to internally wrap/add the ByteArrayInputStream in isZipStream() and autoclose it with a tryWithresources construct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org