ottlinger commented on PR #413:
URL: https://github.com/apache/creadur-rat/pull/413#issuecomment-2539149613
I merged in master and HeaderCheckWorkerTest is broken.
@Claudenw Is it intended that the license family "unknown" is approved by
default?
```
+++
b/apache-rat-core/src/test/java/org/apache/rat/analysis/HeaderCheckWorkerTest.java
@@ -43,8 +43,8 @@ public class HeaderCheckWorkerTest {
ILicense matcher = new TestingLicense("test", "test");
HeaderCheckWorker worker = new HeaderCheckWorker(new
TestingMatcher(), new StringReader(""), Lists.list(matcher), subject);
worker.read();
-
assertThat(subject.getMetaData().unapprovedLicenses().count()).isEqualTo(1);
-
assertThat(subject.getMetaData().unapprovedLicenses().collect(Collectors.toList()).get(0).getLicenseFamily()).isEqualTo(ILicenseFamily.UNKNOWN);
+
assertThat(subject.getMetaData().approvedLicenses().count()).isEqualTo(1);
+
assertThat(subject.getMetaData().approvedLicenses().collect(Collectors.toList()).get(0).getLicenseFamily()).isEqualTo(ILicenseFamily.UNKNOWN);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
