Claudenw commented on PR #413: URL: https://github.com/apache/creadur-rat/pull/413#issuecomment-2541226854
Nope. Unknown lice se can not be approved unless specifically added by the user. I will check on this this weekend On Thu 12 Dec 2024, 14:44 P. Ottlinger, ***@***.***> wrote: > I merged in master and HeaderCheckWorkerTest is broken. > > @Claudenw <https://github.com/Claudenw> Is it intended that the license > family "unknown" is approved by default? > > +++ b/apache-rat-core/src/test/java/org/apache/rat/analysis/HeaderCheckWorkerTest.java > @@ -43,8 +43,8 @@ public class HeaderCheckWorkerTest { > ILicense matcher = new TestingLicense("test", "test"); > HeaderCheckWorker worker = new HeaderCheckWorker(new TestingMatcher(), new StringReader(""), Lists.list(matcher), subject); > worker.read(); > - assertThat(subject.getMetaData().unapprovedLicenses().count()).isEqualTo(1); > - assertThat(subject.getMetaData().unapprovedLicenses().collect(Collectors.toList()).get(0).getLicenseFamily()).isEqualTo(ILicenseFamily.UNKNOWN); > + assertThat(subject.getMetaData().approvedLicenses().count()).isEqualTo(1); > + assertThat(subject.getMetaData().approvedLicenses().collect(Collectors.toList()).get(0).getLicenseFamily()).isEqualTo(ILicenseFamily.UNKNOWN); > } > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/creadur-rat/pull/413#issuecomment-2539149613>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AASTVHQVV46VIDZC2AXX3Y32FGOK7AVCNFSM6AAAAABTLVX2FKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZZGE2DSNRRGM> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
