[ 
https://issues.apache.org/jira/browse/CRUNCH-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878054#comment-16878054
 ] 

Josh Wills commented on CRUNCH-635:
-----------------------------------

[~sshagarwal] this is great, thank you! My only quibble is with making the 
WritableTableType have public scope; the way I usually handled this sort of 
check other places was two-fold: 1) Is the PType a PTableType? and 2) does the 
PTypeFamily the WritableTypeFamily? I don't think it makes a material 
difference in the impl, but I like keeping package scope stuff essentially the 
same going forward. If you don't object, I'm happy to make that change and 
merge the patch with it.

> MultipleOutput Text Targets
> ---------------------------
>
>                 Key: CRUNCH-635
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-635
>             Project: Crunch
>          Issue Type: Improvement
>          Components: IO
>            Reporter: Jim McStanton
>            Priority: Minor
>         Attachments: CRUNCH-635.patch
>
>
> CRUNCH-306 was logged to add the ability to write an output file per key in a 
> PTable. The original issue covers just Avro output files, this Improvement 
> would extend this by adding support for Text file targets. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to