shayshim commented on a change in pull request #343: [CURATOR-557]
ServiceCacheImpl does not close ExecutorService
URL: https://github.com/apache/curator/pull/343#discussion_r371491756
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceProviderBuilder.java
##########
@@ -71,4 +74,23 @@
* @return this
*/
public ServiceProviderBuilder<T> additionalFilter(InstanceFilter<T>
filter);
+
+ /**
+ * Optional ExecutorService to use for the cache's background thread. The
specified ExecutorService
+ * will be wrapped in a CloseableExecutorService and overrides any prior
ThreadFactory or ExecutorService
Review comment:
Should be `... and overrides any prior ThreadFactory or
CloseableExecutorService` (instead of `ExecutorService`), no?
Same question for next method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
