shayshim commented on a change in pull request #343: [CURATOR-557]
ServiceCacheImpl does not close ExecutorService
URL: https://github.com/apache/curator/pull/343#discussion_r372640591
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceCacheBuilder.java
##########
@@ -46,6 +46,7 @@
* @param threadFactory factory
* @return this
*/
Review comment:
Sorry if I wasn't clear, but I didn't mean to drop the `@Deprecated`.
`@Deprecated` and `@deprecated` should be used together. Please refer to:
https://docs.oracle.com/javase/8/docs/technotes/guides/javadoc/deprecation/deprecation.html
Their conclusion is "Thus, using the `@Deprecated` annotation to generate
warnings is more portable that relying on the `@deprecated` Javadoc tag."
Same for `ServiceProviderBuilder.threadFactory(...)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
