shayshim commented on a change in pull request #343: [CURATOR-557]
ServiceCacheImpl does not close ExecutorService
URL: https://github.com/apache/curator/pull/343#discussion_r372648860
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceCacheBuilder.java
##########
@@ -46,6 +46,7 @@
* @param threadFactory factory
* @return this
*/
Review comment:
Also, it turns out that deprecation of interface method doesn't affect
overriding methods, as said in the same link:
"It is possible for a non-deprecated property to hide or override a
deprecated one, which removes deprecation. As developer of an API, it is your
responsibility to deprecate overrides of a deprecated method, if in fact they
should be deprecated."
Could you deprecate also the two `threadFactory(...)` overriding methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
