TisonKun commented on a change in pull request #348: CURATOR-562 Remove
ConnectionHandlingPolicy
URL: https://github.com/apache/curator/pull/348#discussion_r390159535
##########
File path: curator-client/src/main/java/org/apache/curator/ConnectionState.java
##########
@@ -218,7 +216,7 @@ public String call()
};
int lastNegotiatedSessionTimeoutMs =
getLastNegotiatedSessionTimeoutMs();
int useSessionTimeoutMs = (lastNegotiatedSessionTimeoutMs > 0) ?
lastNegotiatedSessionTimeoutMs : sessionTimeoutMs;
- ConnectionHandlingPolicy.CheckTimeoutsResult result =
connectionHandlingPolicy.checkTimeouts(hasNewConnectionString,
connectionStartMs, useSessionTimeoutMs, connectionTimeoutMs);
+ CheckTimeoutsResult result = checkTimeouts(hasNewConnectionString,
connectionStartMs, useSessionTimeoutMs, connectionTimeoutMs);
Review comment:
Yes. I mentioned it in the JIRA and commit message.
>Besides, some values in CheckTimeoutsResult seems out of day that we might
have a follow-up to handle it.
I'd prefer do it in another cycle so that I have cycle to understand the
impact by removing it :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
