TisonKun commented on a change in pull request #348: CURATOR-562 Remove
ConnectionHandlingPolicy
URL: https://github.com/apache/curator/pull/348#discussion_r390162126
##########
File path: curator-client/src/main/java/org/apache/curator/ConnectionState.java
##########
@@ -218,7 +216,7 @@ public String call()
};
int lastNegotiatedSessionTimeoutMs =
getLastNegotiatedSessionTimeoutMs();
int useSessionTimeoutMs = (lastNegotiatedSessionTimeoutMs > 0) ?
lastNegotiatedSessionTimeoutMs : sessionTimeoutMs;
- ConnectionHandlingPolicy.CheckTimeoutsResult result =
connectionHandlingPolicy.checkTimeouts(hasNewConnectionString,
connectionStartMs, useSessionTimeoutMs, connectionTimeoutMs);
+ CheckTimeoutsResult result = checkTimeouts(hasNewConnectionString,
connectionStartMs, useSessionTimeoutMs, connectionTimeoutMs);
Review comment:
If you think we'd better include the removal of `CheckTimeoutsResult` in
this pr, we can hold it and let me try to investigate in time/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
