bigmarvin edited a comment on issue #355: [CURATOR-464] attach orignal 
artifacts with classifier original
URL: https://github.com/apache/curator/pull/355#issuecomment-604842044
 
 
   Updating the title and the commit of this PR.
   
   Following alternative #2, I propose a new change where projects of type jar 
or bundle would have original artifacts attached, with classifier 'original'. 
It's better than 'slim', as shading does more than simply including. The byte 
code of curator classes is also changed during shading, e.g. imports of google 
guava packages become imports of relocated guava packages.
   
   Though listed in supported types in the bundle plugin, projects of type war 
are not included in this change, because those projects simply packs everything 
in the dependency tree into artifacts, and they don't have separation in class 
loading.
   
   Projects of type jar, on the other hand, could produce artifacts usable as 
bundles, by planting headers required by OSGi runtime into manifest during 
packaging, so they are included.
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to