bigmarvin opened a new pull request #355: [CURATOR-464] attach shaded artifacts 
with classifier uber
URL: https://github.com/apache/curator/pull/355
 
 
   Would like to revisit the following issue.
   
   https://issues.apache.org/jira/browse/CURATOR-464
   
   The current approach would be preventing shaded artifacts from replacing 
original artifacts. Instead, shaded artifacts are now also attached with 
classifier uber, next to original artifacts, so clients could integrate either 
based on their need.
   
   This approach is my preference while it'll be a little expensive in 
adoption, as classifier must be added. If this really bothers, here are 2 
alternatives we may go:
   
   1. **Removal of reloaction in shading.** Packages like 
`org.apache.curator.shaded.com.google` could be found nowhere but in 
curator-client, which however doesn't export these relocated packages in its 
manifest. Without relocation, these packages could be fulfilled by some other 
bundle, following the import instruction inside the manifest. However, if 
shaded classes take priority, problems could be expected in OSGi runtime 
because same classes are loaded by different bundles and they become different 
classses.
   
   2. **Attaching original artifact with some classifier like 'slim'.** This is 
essentially the reverse way of the proposed approach, which however costs 
little in adoption as no classifier is required. Personally, I don't like this 
way as we don't usually put classifier on original artifacts. However, if 
compared with this issue not being fixed, this alternative would be better.
   
   Please review the change and any comment is welcome.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to