shayshim commented on a change in pull request #336: [CURATOR-549] Bridge facade for ModeledCache and ServiceCache, etc. URL: https://github.com/apache/curator/pull/336#discussion_r403524822
########## File path: curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestGroupMember.java ########## @@ -25,11 +25,13 @@ import org.apache.curator.retry.RetryOneTime; import org.apache.curator.test.BaseClassForTests; import org.apache.curator.test.Timing; +import org.apache.curator.test.compatibility.CuratorTestBase; import org.apache.curator.utils.CloseableUtils; import org.testng.Assert; import org.testng.annotations.Test; import java.util.Map; +@Test(groups = CuratorTestBase.zk35TestCompatibilityGroup) Review comment: Can you remind why do we need it now? It will make the test run if this env has 3.5 and up? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
