shayshim commented on a change in pull request #336: [CURATOR-549] Bridge
facade for ModeledCache and ServiceCache, etc.
URL: https://github.com/apache/curator/pull/336#discussion_r403543136
##########
File path:
curator-x-async/src/main/java/org/apache/curator/x/async/modeled/details/ModeledCacheImpl.java
##########
@@ -148,38 +165,32 @@ public void childEvent(CuratorFramework client,
TreeCacheEvent event)
}
}
- private void internalChildEvent(TreeCacheEvent event) throws Exception
+ private void internalChildEvent(TreeCacheEvent event)
Review comment:
In case of `TreeCache`, this code can called from `Executor`, but in case of
`CuratorCache`, it can be called only on the event thread. No way it can be an
issue?
It could add itself as listener also using `addListener(T listener, Executor
executor)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
