eolivelli commented on a change in pull request #367:
URL: https://github.com/apache/curator/pull/367#discussion_r442279406
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
##########
@@ -78,7 +79,7 @@ private static ExecutorService
convertThreadFactory(ThreadFactory threadFactory)
this.discovery = discovery;
- String path = discovery.pathForName(name);
+ path = discovery.pathForName(name);
Review comment:
`I'm surprised we don't have a test for this`
If you run tests you will see the error in the logs, but the error is
swallowed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
